feat(playground): add tools ui #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parker-Stafford
force-pushed
the
parker/4902-playground-tools-ui
branch
from
2d394a3
to
0c71f2d
Compare
| linter(jsonParseLinter()), | ||
| linter(jsonSchemaLinter(), { needsRefresh: handleRefresh }), | ||
| jsonLanguage.data.of({ | ||
| autocomplete: jsonCompletion(), |
mikeldking
reviewed
Oct 15, 2024
| "theme" | "extensions" | "editable" | ||
| >; | ||
|
|
||
| export function JSONToolEditor(props: JSONToolEditorProps) { |
There was a problem hiding this comment.
Isn't this really JSONEditor with json schema added on top?
There was a problem hiding this comment.
Yeah i had baked in the tool schema, so that's what makes it "tool" I guess but i could either
- modify the json editor to accept a schema and conditionally add the extensions or
- make a new jsoneditorwithschema (still would need to take in a schema as a prop)
There was a problem hiding this comment.
removed and extended the jsonEditor
Parker-Stafford
force-pushed
the
parker/4902-playground-tools-ui
branch
from
e8ee023
to
55a6024
Compare
dosubot
bot
added
size:L
| <div | ||
| key={i} | ||
| key={instance.id} | ||
| css={css` | ||
| flex: 1 1 0px; |
There was a problem hiding this comment.
Can we add some flex gap?
There was a problem hiding this comment.
ahh yes thank you i saw this then forgot to circle back
mikeldking
force-pushed
the
parker/4902-playground-tools-ui
branch
from
82cab7a
to
bedd86b
Compare
mikeldking
reviewed
Oct 15, 2024
| jsonSchemaLinter, | ||
| stateExtensions, | ||
| } from "codemirror-json-schema"; | ||
| import { JSONSchema7 } from "json-schema"; |
There was a problem hiding this comment.
the version of the json schema spec i believe
mikeldking
reviewed
Oct 15, 2024
Comment on lines
+39
to
+45
| const toolNames = useMemo( | ||
| () => | ||
| tools | ||
| .map((tool) => tool.definition.function?.name) | ||
| .filter((name): name is NonNullable<typeof name> => name != null), | ||
| [tools] | ||
| ); |
There was a problem hiding this comment.
note there's a slight bug here if the names collide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4902
Screen.Recording.2024-10-15.at.10.53.34.AM.mov
with choice selector
